Avoid InstallValue for non-plain objects #55
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InstallValue is one of a tiny handful of places calling the GAP kernel function CLONE_OBJ. This function is rather dangerous, e.g. for *types* it is not really well-defined, see gap-system/gap#1637. While I am not aware of any ill-effects of the usage here, I think it is best to avoid it (and perhaps we can at some point even phase out support for `InstallValue` used on non-plain objects)
|
Thanks for the suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstallValue is one of a tiny handful of places calling the GAP kernel
function CLONE_OBJ. This function is rather dangerous, e.g. for types it is
not really well-defined, see gap-system/gap#1637.
While I am not aware of any ill-effects of the usage here, I think it is best
to avoid it (and perhaps we can at some point even phase out support for
InstallValueused on non-plain objects)