-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse rgba correctly #81
Conversation
hm.. i think its still not working 100% as it should:
renders the wob black on black for me, while everything works nicely with red:
|
added a test with printing the values and it confirms my comment from earlier. while the red value is saved correctly, the green-ish value is just black. any ideas as to why @francma ? |
Looks like I've broken it in 6b1db6c#diff-8d4a2f7af9d0296ddf4f7d8c6af88631fe880014944ec713512585530ee1f853R10. It should look like this to have correct operator precedence.
Can you please make this change as part of this PR? |
56fc3c3
to
bcdba72
Compare
have you got an idea why the clang-format test fails? |
Probably clang version mismatch - pipeline has clang 10 vs clang 11 on our local machines. I've updated pipeline to clang 11 so it will hopefully work after rebase from master. |
ya, worked! tyvm! |
apparently I did not test this properly and introduced an error parsing the rgba value while cherry-picking