Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Crash when adding files to newly created repository. #251

Closed
hilpara opened this issue Jun 26, 2022 · 1 comment
Closed

[BUG] Crash when adding files to newly created repository. #251

hilpara opened this issue Jun 26, 2022 · 1 comment
Assignees
Labels
Bug Bug that makes GitQlient unstable. It doesn't crash Solved This issues has been solved!

Comments

@hilpara
Copy link

hilpara commented Jun 26, 2022

Describe the bug
GitQlient crashes on newly created repo after adding a file.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new local repository.
  2. Add a file to the folder
  3. Wait for update event (void GitQlientRepo::updateUiFromWatcher())
  4. It will crash
    void GitCache::insertWipRevision(const QString parentSha, const RevisionFiles &files) { ... if (mCommits[0]) <- beause mCommits has 0 items and it tries to access the index 0. ... }

Expected behavior
It should not crash.

Screenshots

Desktop (please complete the following information):

  • OS: Arch
  • Release version or SHA: 1.50 (Appimage) and 4e4b74d
  • If manually compiled, compiler version:

Additional context
Actually, is there a possibility to add the first branch before adding files? At the moment I see the only option is to do this all first on CLI and afterwards use the GitQlient.

@hilpara hilpara added the Bug Bug that makes GitQlient unstable. It doesn't crash label Jun 26, 2022
@hilpara hilpara changed the title [BUG] [BUG] Crash when adding files to newly created repository. Jun 26, 2022
@francescmm
Copy link
Owner

I'm on it, @hilpara! Thanks for reporting!

@francescmm francescmm added the Solved This issues has been solved! label Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug that makes GitQlient unstable. It doesn't crash Solved This issues has been solved!
Projects
None yet
Development

No branches or pull requests

2 participants