[BUG] [MacOS] "gitqlient" is damaged and can't be opened

[harens]

Describe the bug

When I try to run the macOS app from the 1.4.3 release dmg, it appears damaged.

I think it has to do with how the app is signed, since wiverson/maven-jpackage-template#49 (comment) fixes it for me:

sudo xattr -rd com.apple.quarantine gitqlient.app

To Reproduce
Steps to reproduce the behavior:

1. Download the 1.4.3 release dmg.
2. Double click the app.

Expected behavior
It's expected to run accordingly.

Screenshots

On a side note, the icon doesn't show and I'm not sure why. This issue might be specific to me, but I thought I'd mention it.

Desktop (please complete the following information):

• OS: macOS 11.1 20C69 x86_64
• Release version or SHA: 1.4.3
• If manually compiled, compiler version: N/A

Additional context

I really love this project, so I wanted to help how I could. I don't think I can assist in fixing this, but I have an alternative solution. PR incoming. 🚀

Thank you for your help 😃

[francescmm]

Hi @harens and thanks for the contribution! I'll merge the PR and hopefully I'll make some time next week to check the issue on MacOS.

Last time I compiled it worked although the signing was an issue. The problem is that it seems I need to pay a "yearly" fee to Apple to sign a package what is not going to happen in an open source and free software. I'm quite furious about them in that regard, hehehe. IDK, may be things have changed :D

[harens]

Hi @harens and thanks for the contribution! I'll merge the PR and hopefully I'll make some time next week to check the issue on MacOS.

That's very kind of you. Thank you :)

Last time I compiled it worked although the signing was an issue. The problem is that it seems I need to pay a "yearly" fee to Apple to sign a package what is not going to happen in an open source and free software. I'm quite furious about them in that regard, hehehe. IDK, may be things have changed :D

If I produced a dmg that installed into /opt/gitqlient/ that I can be fairly sure gets around the signing issue, would you find that useful? I've done something similar before in lite-xl/lite-xl#626 and I'd be happy to do it here. See that issue for more info.

Thanks again for continuing to keep this really useful project going @francescmm. I am very grateful for the work you've put into this.

[francescmm]

Hi @harens, feel free to ship a PR with the changes! It would be nice if I would get it included as part of the GitHub actions. When I installed GitQlient in the MacBook it was using the file generated by those actions 🤔

[harens]

@francescmm I was just thinking that since nobody else has reported this error until now, it might be better to keep the current setup.

If someone does have this issue, they can run sudo xattr -rd com.apple.quarantine /Applications/gitqlient.app which should fix it for them. It might be simpler just to document this fix? (which I'm happy to do)

[francescmm]

Happy if you can ship a PR. Thanks a lot!