Making sure to notify when plugins have dependencies

francescmm · Jun 25, 2022 · 6833616 · 6833616
1 parent f468e27
commit 6833616
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 4 deletions.
diff --git a/src/aux_widgets/PluginsDownloader.cpp b/src/aux_widgets/PluginsDownloader.cpp
@@ -62,8 +62,17 @@ void PluginsDownloader::processPluginsFile()
 #endif
       if (const auto jsonUrl = QStringLiteral("%1-url").arg(platform); jsonObject.contains(jsonUrl))
       {
-         pluginsInfo.append(PluginInfo { jsonObject["name"].toString(), jsonObject["version"].toString(),
-                                         jsonObject[jsonUrl].toString() });
+         PluginInfo pluginInfo {
+            jsonObject["name"].toString(), jsonObject["version"].toString(), jsonObject[jsonUrl].toString(), {}
+         };
+
+         if (const auto dependencies = QStringLiteral("dependencies"); jsonObject.contains(dependencies))
+         {
+            for (auto dependency : jsonObject[dependencies].toArray())
+               pluginInfo.dependencies.append(std::move(dependency.toString()));
+         }
+
+         pluginsInfo.append(std::move(pluginInfo));
       }
    }
 

diff --git a/src/aux_widgets/PluginsDownloader.h b/src/aux_widgets/PluginsDownloader.h
@@ -38,6 +38,7 @@ struct PluginInfo
    QString name;
    QString version;
    QString url;
+   QStringList dependencies;
 };
 
 class PluginsDownloader : public QObject

diff --git a/src/big_widgets/ConfigWidget.cpp b/src/big_widgets/ConfigWidget.cpp
@@ -268,8 +268,17 @@ void ConfigWidget::onPluginsInfoReceived(const QVector<PluginInfo> &pluginsInfo)
       ui->availablePluginsLayout->addWidget(new QLabel(plugin.version), row, 1);
 
       const auto pbDownload = new QPushButton("Download");
-      connect(pbDownload, &QPushButton::clicked, this,
-              [url = plugin.url, this]() { mPluginsDownloader->downloadPlugin(url); });
+      connect(pbDownload, &QPushButton::clicked, this, [url = plugin.url, dependencies = plugin.dependencies, this]() {
+         if (!dependencies.empty())
+         {
+            QMessageBox::information(
+                this, tr("Dependencies needed!"),
+                tr("This plugin needs some dependencies to work. Please make sure you have them instsalled:<br><br>%1")
+                    .arg(dependencies.join("<br>")));
+         }
+
+         mPluginsDownloader->downloadPlugin(url);
+      });
       mDownloadButtons->addButton(pbDownload);
 
       pbDownload->setDisabled(mPluginNames.contains(plugin.name) || ui->lePluginsDestination->text().isEmpty());