Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide way to set both status code and status text in renderData() #385

Closed
seancorfield opened this issue Oct 21, 2015 · 2 comments
Closed

Provide way to set both status code and status text in renderData() #385

seancorfield opened this issue Oct 21, 2015 · 2 comments
Assignees
@seancorfield
Labels
enhancement
Milestone
4.0

Comments

@seancorfield
Copy link
Member

Currently you can only specify the status code in renderData() but it would be useful to be able to specify status text as well sometimes. Since the JSONP callback is the optional 4th argument, probably the easiest way to support this is to allow status code to be either a numeric value on its own (as now) or a vector pair of status code and text.
@seancorfield seancorfield self-assigned this Oct 21, 2015
@seancorfield seancorfield added this to the 3.6 milestone Oct 21, 2015
@seancorfield
Copy link
Member Author

The nicest way to support this would be via #388 but that's pending input from the community.

@seancorfield
Copy link
Member Author

Note: setStatus( int, String ) is actually deprecated but we do not want to use sendError( int, String ) here.

seancorfield added a commit that referenced this issue Oct 31, 2015
@seancorfield
Fix #385 #388 by adding builder syntax and statusText support
ef72f0c
seancorfield added a commit that referenced this issue Nov 1, 2015
@seancorfield
Proper status/error handling for #385
6515f8d
seancorfield added a commit that referenced this issue Nov 4, 2015
@seancorfield
Rollback sendError() change in #385
f57c153 
As I noted in the comments, using `sendError()` is not what we want
anyway. I should have listened to myself :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seancorfield seancorfield

Labels
enhancement
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
1 participant
@seancorfield