Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardware accelerated scroll animations #2259

Merged
merged 6 commits into from
Jul 27, 2023
Merged

Hardware accelerated scroll animations #2259

merged 6 commits into from
Jul 27, 2023

Conversation

mattgperry
Copy link
Collaborator

@mattgperry mattgperry commented Jul 27, 2023 •
edited
Loading

This PR adds support for hardware-accelerated scroll animations where available.

scroll(
  animate(element, { transform: ["none", "scale(0)"] })
)

adamseckel
adamseckel reviewed Jul 27, 2023
View reviewed changes
packages/framer-motion/src/render/dom/scroll/observe.ts Outdated
frame.update(onFrame, true)

return () => {
console.log("cancel timeline observation")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we drop this before merging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@mattgperry mattgperry added the automerge Land this PR label Jul 27, 2023
@mergetron mergetron bot removed the autorebasing label Jul 27, 2023
@mergetron mergetron bot merged commit 8090668 into main Jul 27, 2023
@mergetron mergetron bot deleted the feature/scroll-animate branch July 27, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamseckel adamseckel adamseckel approved these changes

Assignees
No one assigned
Labels
automerge Land this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattgperry @adamseckel