Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hover event supression during layout measurements #1157

Merged
merged 2 commits into from
May 17, 2021

Conversation

mattgperry
Copy link
Collaborator

From testing, hover events don't fire if an element moves from under the element. I remember there was an effect like this in Framer but fundamentally they don't. So in this PR we remove this, if this kind of effect causes more issues we can find an alternative fix for the actual problem.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cc0418f:

Sandbox Source
Framer Motion: Simple animation Configuration
App Store UI using React and Framer Motion Configuration
Framer Motion: Reorder animation Configuration
Framer Motion: growing item positionTransition issue Configuration
Framer Motion: Image lightbox Configuration

Copy link
Collaborator

@adamseckel adamseckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mattgperry mattgperry added the automerge Land this PR label May 17, 2021
@mergetron mergetron bot merged commit dce8305 into main May 17, 2021
@mergetron mergetron bot deleted the fix/hover-supression branch May 17, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Land this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants