Adding support for scan and flushdb commands.
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fppt
approved these changes
Apr 11, 2019
| return Response.array(response); | ||
| } | ||
|
|
||
| private static Slice extractParameter(List<Slice> params, String name) { |
There was a problem hiding this comment.
So I am being a bit nitpicky but I would say rather return an Optional<Slice> here. This will clean up your consumer calls, i.e. rather than:
Slice matchSlice = extractParameter(params(), MATCH);
String match = matchSlice != null ? matchSlice.toString() : "*";
to
String match = extractParameter(params(), MATCH).orElse("*")
There was a problem hiding this comment.
Done! It's a bit more involved as extractParameter returns Slice and not String.
| @@ -87,4 +87,32 @@ public static int convertToInteger(String value){ | |||
| throw new WrongValueTypeException("ERR bit offset is not an integer or out of range"); | |||
| } | |||
| } | |||
|
|
|||
| public static String createRegexFromGlob(String glob) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there is only 1 database, so I've made the
flushdbcommand perform the same exact operation asflushall.Resolves #33