Week 5 Ex 1, 2, 3, 4, 5 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shineli1984
reviewed
Sep 8, 2019
shineli1984
approved these changes
Sep 9, 2019
|
|
||
| instance Expr Mod7 where | ||
| lit a = Mod7 $ mod a 7 | ||
| add (Mod7 a) (Mod7 b) = Mod7 $ lit (a + b) |
There was a problem hiding this comment.
nit:
Normally, we use function composition style:
Suggested change
| add (Mod7 a) (Mod7 b) = Mod7 $ lit (a + b) | |
| add (Mod7 a) (Mod7 b) = Mod7 . lit $ (a + b) |
|
Good work! |
stevemao
added a commit
that referenced
this pull request
Sep 15, 2019
* master: week 6 (#85) Week6 (#83) Fix warnings in week 1-5 (#84) Daniel M Week 5 (#81) Update README.md Week5-T1,T2,T3,T4 (#77) Wei Ning CIS194 Week 5 homework (#80) Daniel Deng Week04 - Exercise 02 ~ 04 (#79) Fix some nits (#78) Week5 Ex 1, 2, 3, 4, 5 (#67) Week4 (#70) Week 5 ex 2 to 6 (#76) week 5: use applicative and composition styles (#75)
cht8687
added a commit
to cht8687/2019-winter-Haskell-school
that referenced
this pull request
Sep 16, 2019
* upstream/master: generalize Num (Stream a) instance (fp-works#87) Fix Week6 nits (fp-works#86) week 6 (fp-works#85) Week6 (fp-works#83) Fix warnings in week 1-5 (fp-works#84) Daniel M Week 5 (fp-works#81) Update README.md Week5-T1,T2,T3,T4 (fp-works#77) Wei Ning CIS194 Week 5 homework (fp-works#80) Daniel Deng Week04 - Exercise 02 ~ 04 (fp-works#79) Fix some nits (fp-works#78) Week5 Ex 1, 2, 3, 4, 5 (fp-works#67) Week4 (fp-works#70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not too sure about Ex3. Any feedback is greatly appreciated.
Thanks.