Stevemao w11 #135
Merged
Stevemao w11 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shineli1984
approved these changes
Oct 26, 2019
| deriving Show | ||
|
|
||
| parseSExpr :: Parser SExpr | ||
| parseSExpr = spaces *> noSpace <* spaces |
There was a problem hiding this comment.
nit:
Does p1 *> p <* p2 mean p between p1 and p2? if so, it seems like we can have a parser called between.
|
|
||
| parseSExpr :: Parser SExpr | ||
| parseSExpr = spaces *> noSpace <* spaces | ||
| where noSpace = toN posInt <|> toI ident <|> char '(' *> oneOrMoreSExprs <* char ')' |
There was a problem hiding this comment.
nit:
With between parser, we can build a parser called inBrackets and use it here.
cht8687
added a commit
to cht8687/2019-winter-Haskell-school
that referenced
this pull request
Oct 27, 2019
* upstream/master: Week6f (fp-works#150) Week5f (fp-works#149) Week4f (fp-works#148) Daniel M Week11 (fp-works#147) Daniel M - Week 10 (fp-works#146) Week 10 & Week 11 (fp-works#145) Stevemao w11 (fp-works#135) Week10 (fp-works#136) Week 10 fix nits (fp-works#143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.