Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reuse inflight buf in lodc to reduce alloc and page fault #871

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Mar 5, 2025

Signed-off-by: MrCroxx mrcroxx@outlook.com## What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

Before:

image

After:

image

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #870

Appendix

Before:

foyer blob

After:

foyer alloc

MrCroxx added 2 commits March 5, 2025 12:55
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added the perf Performance optimization label Mar 5, 2025
@MrCroxx MrCroxx added this to the v0.15 milestone Mar 5, 2025
@MrCroxx MrCroxx self-assigned this Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-storage/src/large/flusher.rs 87.50% 2 Missing ⚠️
Files with missing lines Coverage Δ
foyer-storage/src/io/mod.rs 71.87% <100.00%> (+0.29%) ⬆️
foyer-storage/src/large/flusher.rs 85.79% <87.50%> (-0.24%) ⬇️

@MrCroxx MrCroxx changed the title chore: remove some unnecessary comments perf: reuse inflight buf in lodc to reduce alloc and page fault Mar 5, 2025
@MrCroxx MrCroxx merged commit d928457 into main Mar 5, 2025
33 checks passed
@MrCroxx MrCroxx deleted the xx/alloc branch March 5, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf Performance optimization
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

perf: reduce page fault with the new lodc blob writer
1 participant