This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Do not ignore crashes by only handling PickleException #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a case where annotation processor would fail because of an unexpected error. I think it was IndexOutOfBoundsException. And the output would only say `Pickle Error: ` with no proper stacktrace.
fourlastor
approved these changes
Oct 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a case where annotation processor would fail because of an unexpected error. I think it was IndexOutOfBoundsException. And the output would only say
Pickle Error:with no proper stacktrace.I believe this will actually help identify the issues in case something wrong happens internally with Pickle.