Allow running pickle on unit tests

[fourlastor]

No description provided.

[tasomaniac]

Out of scope but I have some feedback about this.

People generally tend to copy paste what they saw. When we first implementing, we just copy pasted here and that means strictMode was false. We couldn't figure out what's wrong since no tests were generated. (We had missing steps).

I think it is a good idea to keep the example to defaults even though you say defaults to false next.

[fourlastor]

I'll do it now cause it's a very good point d3e33eb

[tasomaniac]

I wonder if you can do

project.extensions.findByType(TestedExtension::class.java)?.run {

here?

[tasomaniac]

this will enable us to merge 2 branches. And also probably will support other plugins like instant-apps, dynamic-delivery etc.

[fourlastor]

Good point but it requires a bit more testing, I'll open an issue

[tasomaniac]

Definitely makes sense

[tasomaniac]

Since this is called for both tasks, accessing mergeAssets causes

Caused by: kotlin.UninitializedPropertyAccessException: lateinit property mergeAssetsTask has not been initialized

The dependency should be different for unit tests.

[fourlastor]

You're very right 🤦‍♂️ my bad, forgot about this one

[tasomaniac]

I've tested this with our project. I had lots of other problems with Robolectric but that is out of scope. This seems to work perfectly. 👍 It was able to generate code for unit tests.

I have a suggestion for the extension. What about something like below:

androidTest {
    enabled = true
    featuresDir = ....
}
unitTest {
   enabled = true
   featuresDir = ....
}

[fourlastor]

@tasomaniac do you mean

pickle {
  androidTest { }
  unitTest { }
}

?

[tasomaniac]

Exactly 👍 It is just an idea.

[fourlastor]

It does sound good! I'll give it a try this weekend 👍