-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add git based bundling strategy #7
Draft
chrismcg
wants to merge
14
commits into
main
Choose a base branch
from
cmg/add-package-version-bundling-strategy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismcg
changed the title
feat: Add package version bundling strategy
feat: Add git based bundling strategy
Nov 29, 2024
A copy of the SOURCE tests to start.
Make the functions both depend on common and have different external dependencies.
These are not working correctly yet as `uv sync` is changing the lockfile in a way that's breaking things. Committing so can make a PR and get help debugging further.
If we're not using a package in a workspace app then use the last commit hash for the entire rootDir and anything in git diff to generate the custom hash for CDK bundling. If we are using a package in a workspace app then get the list of dependencies and check and local ones for changes. This uses the hash of the last commit and any git diff in that part of the tree for each dependency and the package itself.
Couldn't get the tests to pass so removing for now until we can figure out why and put it back in.
chrismcg
force-pushed
the
cmg/add-package-version-bundling-strategy
branch
from
January 7, 2025 15:18
b9a57a2
to
ab30700
Compare
chrismcg
force-pushed
the
cmg/add-package-version-bundling-strategy
branch
4 times, most recently
from
January 8, 2025 16:54
ee1264c
to
ba7454f
Compare
chrismcg
force-pushed
the
cmg/add-package-version-bundling-strategy
branch
from
January 8, 2025 17:18
ba7454f
to
40d0164
Compare
Signed-off-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for specifying a
bundlingStrategy
as part of thebundling
params. If this isBundlingStrategy.SOURCE
then do the same as before. If it'sBundlingStrategy.GIT
then use git command output to decide if the package needs rebuilt or not.If we're not using a package in a workspace app then use the last commit hash for the entire
rootDir
and anything ingit diff
to generate the custom hash for CDK bundling.If we are using a package in a workspace app then get the list of dependencies and check and local ones for changes. This uses the hash of the last commit and any git diff in that part of the tree for each dependency and the package itself.
As this involved editing files in the project the tests add some helper functions to clone the workspace to a temporary directory and do the edits there.
This PR originally had the PACKAGE_VERSION bundling strategy but it's been removed as the tests couldn't be made to pass because of something uv related so lower confidence it would work in practise.