Fixed flaky tests

[TonioGela]

Closes #455.

See this comment for details.

[TonioGela]

ofc the "Fixed flaky tests" PR has flaky tests

[TonioGela]

I would really like to spot the problem, but testing locally 100 times with jdk 11 I haven't been able to reproduce it. Any idea @eed3si9n?

[eed3si9n]

Maybe the property based testing doesn't need to consider version numbers with hanzi/kanji characters in them?

[info] ! StableVersion.ordering: Falsified after 943 passed tests.
[info] > Labels of failing property: 
[info] Reversing and sorting should be the same as sorting. Expected version: 365.181.24.0-臿揧氛-䗶蒳쬍㣴ꂦ-弮堢䋊弑⯄೏즃㴼㼺䀧᪟⿽, but got: 365.181.24-㦧녦-㓒ꑡ-Ყ懸喺݄辺芭ᤀ

[TonioGela]

Wow, how did you picked that line in that huge log? Btw, I think you're right, in a few I'll push a fix for that

[TonioGela]

Is not so trivial, after some iterations I get errors like this

failing seed for StableVersion.ordering is 7cjg5dZl9xbfN9xQFEJ2dWFH63NCIWZuWFMC77gKS2C=
[info] ! StableVersion.ordering: Falsified after 20155 passed tests.
[info] > Labels of failing property:
[info] Reversing and sorting should be the same as sorting. Expected version: 319.975.54.0-J4-im1-iquf4jladvx, but got: 319.975.54-V50uE2WjP1
[info] > ARG_0: List(319.975.54.0-J4-im1-iquf4jladvx, 319.975.54-V50uE2WjP1)

even if I set something strict like

private val genChar = Gen.alphaNumChar

I'll investigate further

[TonioGela]

I don't know why but in this commit this line was added:

numbers = prefix.toSeq ++: vn.numbers.drop(prefix.length)

To the best of my understanding, this should concatenate and empty list to prefix.toSeq, but sometimes the net effect is that lists like List(83, 39, 374) became List(83, 39, 374, 0) and so the test fails.

Removing this map the test passed flawlessly

genVersionNumber.map { vn =>
          VersionNumber(
            numbers = prefix.toSeq ++: vn.numbers.drop(prefix.length),
            tags = vn.tags,
            extras = vn.extras
          )
        }

[eed3si9n]

In general feel free to remove any flaky tests too if it's not delivering values. It's not like we have a ton of bug reports complaining about version number parsing.

[TonioGela]

In general, feel free to remove any flaky tests too if it's not delivering values. It's not like we have a ton of bug reports complaining about version number parsing.

Okay 👍 This time, I think I fixed it in a meaningful way btw :)