Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split in expandPath #533

Merged
merged 1 commit into from
Mar 27, 2021

Conversation

sake92
Copy link
Contributor

@sake92 sake92 commented Mar 26, 2021

The toURI().relativize returns path with slashes /.
But in the expandPath it splits by File.separator (\ on windows).
That doesn't work on windows, obviously, different characters.

If we use Files.relativize instead of URL we get '\', but then we get these errors:
Check that all literal '$' are properly escaped with '\$'

So the solution is just to split by /.

Fixes #465

@sake92 sake92 requested review from eed3si9n and xuwei-k as code owners March 26, 2021 15:19
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sake92!
LGTM

@xuwei-k xuwei-k merged commit 1d38c57 into foundweekends:master Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

enable all tests with windows in CI
3 participants