Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure JGitIgnore closes scala.io.Source-s #464

Merged
merged 1 commit into from
May 22, 2020
Merged

Ensure JGitIgnore closes scala.io.Source-s #464

merged 1 commit into from
May 22, 2020

Conversation

er1c
Copy link
Contributor

@er1c er1c commented May 21, 2020

Takes a stab at fixing: #439

At bare minimum, these need to be .close()ed for best practice per the scaladocs, so no harm if this doesn't fix the window issue.

@xuwei-k
Copy link
Member

xuwei-k commented May 21, 2020 

[warn] /home/travis/build/foundweekends/giter8/library/src/main/scala/giter8/JGitIgnore.scala isn't formatted properly!
[info] Checking 1 Scala sources...
[info] Checking 1 Scala sources...
[info] Checking 3 Scala sources...
[error] 1 files must be formatted
[error] (lib / Compile / scalafmtCheck) 1 files must be formatted

https://travis-ci.com/github/foundweekends/giter8/jobs/338287960#L564

@er1c er1c force-pushed the jgitignore-source-close branch 2 times, most recently from 67e2fc9 to 9abea8d Compare May 21, 2020 02:53
@xuwei-k xuwei-k force-pushed the jgitignore-source-close branch 2 times, most recently from f13921b to e2cf4de Compare May 21, 2020 05:00
@er1c er1c force-pushed the jgitignore-source-close branch from e2cf4de to 6c60a10 Compare May 21, 2020 13:35
@er1c
Copy link
Contributor Author

er1c commented May 21, 2020

@xuwei-k thanks for try/finally, I just rebased against master

@er1c er1c force-pushed the jgitignore-source-close branch from e06a428 to 6c60a10 Compare May 21, 2020 21:46
@er1c
Copy link
Contributor Author

er1c commented May 22, 2020 •
edited
Loading

@xuwei-k it looks like almost all of the scripted code will need to be audited for paths for windows, I would merge this and I can see if the non-scripted windows is working

@xuwei-k xuwei-k merged commit 8aba067 into foundweekends:master May 22, 2020
@er1c
Copy link
Contributor Author

er1c commented Jul 1, 2020

@xuwei-k did this get included in a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuwei-k xuwei-k xuwei-k left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@er1c @xuwei-k