Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use search api for maven property. #395

Merged
merged 9 commits into from
Nov 3, 2018

Conversation

kounoike
Copy link
Contributor

@kounoike kounoike commented Sep 3, 2018

Current implementation (using maven-metadata.xml) can't lookup some sbt-plugins such as sbt-gitbucket-plugin. So I tried to solve this problem.

I found REST API in API doc. This API can solve this problem.

xuwei-k
xuwei-k previously requested changes Sep 4, 2018
Copy link
Member

@xuwei-k xuwei-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests

[info] MavenTest:
[info] Maven
[info] - should resolve the latest version when found *** FAILED ***
[info]   The Either on which right.value was invoked was not defined as a Right. (MavenTest.scala:36)
[info] - should return an error when the latest version is not found
[info] - should resolve the latest stable version when the latest version is not stable *** FAILED ***
[info]   The Either on which right.value was invoked was not defined as a Right. (MavenTest.scala:73)
[info] - should return the latest version if the latest version is stable *** FAILED ***
[info]   The Either on which right.value was invoked was not defined as a Right. (MavenTest.scala:95)
[info] - should return an error if the latest stable version is not found
[info] *** 3 TESTS FAILED ***
[error] Failed: Total 55, Failed 3, Errors 0, Passed 52, Ignored 1
[error] Failed tests:
[error] 	giter8.MavenTest
[error] (lib / Test / test) sbt.TestsFailedException: Tests unsuccessful

@kounoike
Copy link
Contributor Author

@xuwei-k OK I fixed tests and my mistakes.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It looks mostly ok except for the use of http.

library/src/main/scala/giter8/MavenHelper.scala Outdated Show resolved Hide resolved
@xuwei-k xuwei-k merged commit dcc95f4 into foundweekends:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants