-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use search api for maven property. #395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuwei-k
previously requested changes
Sep 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix tests
- https://github.com/foundweekends/giter8/blob/df63ff633c4025df72bc873d454a876fb1d4b395/library/src/test/scala/giter8/MavenTest.scala
- https://travis-ci.org/foundweekends/giter8/jobs/424005436#L1629
[info] MavenTest:
[info] Maven
[info] - should resolve the latest version when found *** FAILED ***
[info] The Either on which right.value was invoked was not defined as a Right. (MavenTest.scala:36)
[info] - should return an error when the latest version is not found
[info] - should resolve the latest stable version when the latest version is not stable *** FAILED ***
[info] The Either on which right.value was invoked was not defined as a Right. (MavenTest.scala:73)
[info] - should return the latest version if the latest version is stable *** FAILED ***
[info] The Either on which right.value was invoked was not defined as a Right. (MavenTest.scala:95)
[info] - should return an error if the latest stable version is not found
[info] *** 3 TESTS FAILED ***
[error] Failed: Total 55, Failed 3, Errors 0, Passed 52, Ignored 1
[error] Failed tests:
[error] giter8.MavenTest
[error] (lib / Test / test) sbt.TestsFailedException: Tests unsuccessful
kounoike
force-pushed
the
pr-use-search-api
branch
from
September 5, 2018 23:16
b4fcbb8
to
b0c540b
Compare
kounoike
force-pushed
the
pr-use-search-api
branch
from
September 13, 2018 05:49
b33e9e4
to
9750e88
Compare
@xuwei-k OK I fixed tests and my mistakes. |
eed3si9n
requested changes
Sep 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. It looks mostly ok except for the use of http.
…into pr-use-search-api
eed3si9n
approved these changes
Sep 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation (using maven-metadata.xml) can't lookup some sbt-plugins such as sbt-gitbucket-plugin. So I tried to solve this problem.
I found REST API in API doc. This API can solve this problem.