Add an optional baseDirectory parameter to run() #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
approved these changes
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Giter8.run() is used as a library call, it is impossible to control the directory where the template will be generated: it will always be expanded in a subdirectory of the current directory, as returned by the property "user.dir". However, the calling program may not change its current directory by setting the property: that leads to inconsistencies in the .exists() call on Files, and is generally not supported by the VM, see: http://stackoverflow.com/questions/2275362/java-file-exists-inconsistencies-when-setting-user-dir
This pull request adds a variant to the run() method, where the required output directory can be specified explicitly.