Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Scarb to 2.8.0 #2426

Closed
integraledelebesgue opened this issue Aug 30, 2024 · 3 comments
Closed

Bump Scarb to 2.8.0 #2426

integraledelebesgue opened this issue Aug 30, 2024 · 3 comments
Assignees
@integraledelebesgue
Labels
dependencies Pull requests that update a dependency file new scarb

Comments

@integraledelebesgue
Copy link
Member

integraledelebesgue commented Aug 30, 2024 •
edited
Loading

At the moment, Foundry uses Scarb 2.7.0 in tool-versions. Upgrading to 2.8.0 causes a lot of runtime errors in tests.
However a standard users' "create - declare - deploy" pipeline works fine.
@integraledelebesgue integraledelebesgue self-assigned this Aug 30, 2024
@github-actions github-actions bot added the new label Aug 30, 2024
@integraledelebesgue integraledelebesgue added dependencies Pull requests that update a dependency file scarb labels Aug 30, 2024
@Arcticae
Copy link
Contributor

Arcticae commented Sep 3, 2024

Why do we need to do this? I believe we don't want to upgrade for every version of scarb, we want to keep it as low as possible for compatibility reasons (when it's possible)

@ksew1
Copy link
Collaborator

ksew1 commented Sep 3, 2024

If you ever decide to bump it to 2.8.0 please unignore this test

@ddoktorski ddoktorski mentioned this issue Sep 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 9, 2024
@ddoktorski
Enable coverage test on CI (#2451)
b166289 
<!-- Reference any GitHub issues resolved by this PR -->

Related to #2426 

## Introduced changes

<!-- A brief description of the changes -->

- Removed running `init_new_project` and `init_new_project_from_scarb`
tests for Scarb `2.8.1`. These tests are executed in the job
`test-forge-e2e` with Scarb `2.7.0`
- Enabled running coverage test on CI
@Arcticae
Copy link
Contributor

Discussed offline, closing for now

@Arcticae Arcticae closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@integraledelebesgue integraledelebesgue

Labels
dependencies Pull requests that update a dependency file new scarb
Projects
Starknet foundry
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Arcticae @ksew1 @integraledelebesgue