Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document in appendix that _global cheatcodes work indefinetely #2394

Closed
cptartur opened this issue Aug 26, 2024 · 5 comments · Fixed by #2533
Closed

Document in appendix that _global cheatcodes work indefinetely #2394

cptartur opened this issue Aug 26, 2024 · 5 comments · Fixed by #2533
Assignees
@franciszekjob
Labels
documentation Improvements or additions to documentation snforge

Comments

@cptartur
Copy link
Member

Which components does the task require to be changed? (think hard pls)

snforge

Description

The name suggests that behavior, but it is not documented anywhere. We should update the docs to explain that more clearly.
@cptartur
Copy link
Member Author

https://foundry-rs.github.io/starknet-foundry/appendix/cheatcodes/block_number.html

@github-actions github-actions bot added the new label Aug 26, 2024
@cptartur cptartur added documentation Improvements or additions to documentation snforge labels Aug 26, 2024
@ScottyDavies
Copy link

Hi @cptartur I am open to work on this?

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Aug 26, 2024

Hey @ScottyDavies!
Thanks for showing interest.
We've created an application for you to contribute to Starknet Foundry2.
Go check it out on OnlyDust!

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Aug 26, 2024

Hey @ScottyDavies!
Thanks for showing interest.
We've created an application for you to contribute to Starknet Foundry.
Go check it out on OnlyDust!

@ScottyDavies
Copy link

@cptartur out of curiosity do contributors get paid?

@ScottyDavies ScottyDavies removed their assignment Aug 28, 2024
@cptartur cptartur removed the new label Aug 29, 2024
@cptartur cptartur changed the title Document that _global cheatcodes work indefinetely Document in appendix that _global cheatcodes work indefinetely Sep 23, 2024
@franciszekjob franciszekjob self-assigned this Sep 27, 2024
@franciszekjob franciszekjob mentioned this issue Sep 30, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 30, 2024
@franciszekjob @integraledelebesgue
Add global cheatcodes example and extend appendix (#2533)
f0cbefb 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2394 

## Introduced changes

<!-- A brief description of the changes -->

- Add example of global cheatcode usage in `Using cheatcodes` section
- Extend appendix with global cheatcodes reference

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Jan Smółka <jsmolka@student.agh.edu.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franciszekjob franciszekjob

Labels
documentation Improvements or additions to documentation snforge
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add global cheatcodes example and extend appendix foundry-rs/starknet-foundry
3 participants
@cptartur @franciszekjob @ScottyDavies