Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: account for impersonated tx in configure_tx_env #9553

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: account for impersonated tx in configure_tx_env #9553

merged 2 commits into from
Dec 13, 2024

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Dec 13, 2024 •
edited
Loading

Motivation

impersonated_txs should be accounted for in configure_tx_env

Solution

Handle impersonated txs while configuring env and reset env.tx.caller.

@yash-atreya yash-atreya enabled auto-merge (squash) December 13, 2024 12:34
mattsse
mattsse approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice find,

this looks correct to make, an additional Option arg is really the best we can do here

@yash-atreya yash-atreya merged commit dabacec into master Dec 13, 2024
22 checks passed
@yash-atreya yash-atreya deleted the yash/acc-impersonated branch December 13, 2024 14:37
@grandizzy grandizzy added T-bug Type: bug C-cast Command: cast labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
C-cast Command: cast T-bug Type: bug
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash-atreya @mattsse @grandizzy