feat(anvil): add anvil_getIntervalMining API
#9290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feynman-x
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
|
@grandizzy Followed your suggestion and created this new PR (old #9090). Please check if there is anything to improve. |
grandizzy
reviewed
Nov 9, 2024
|
@grandizzy Yes, it's reasonable. The PR has been updated. |
grandizzy
approved these changes
Nov 9, 2024
grandizzy
changed the title
anvil_getIntervalMining API
|
Thanks for your guidance. I'm so excited, this is my first PR for Foundry. Hope to contribute more in the future. |
holic
reviewed
Nov 9, 2024
| /// Returns the value of mining interval, if set. | ||
| /// | ||
| /// Handler for ETH RPC call: `anvil_getIntervalMing` | ||
| pub fn anvil_get_interval_ming(&self) -> Result<Option<u64>> { |
There was a problem hiding this comment.
should this be anvil_get_interval_mining not anvil_get_interval_ming? (and the comment above)
There was a problem hiding this comment.
thank you! yes indeed, missed the typo 😁 preparing an update in #9292
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
* feat: add anvil_get_interval_mine method * refactor: keep consistent naming --------- Co-authored-by: Your Name <you@example.com> Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #8813
Solution