feat(cheatcodes): mockCall with bytes4 data
#9267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
grandizzy
reviewed
Nov 6, 2024
There was a problem hiding this comment.
I checked again the ticket and I think we got this wrong when discussed action, looks like the proposal is just to add 2 more sigs to make UX better but keep existings @zerosnacks could you also double check please
function mockCall(address where, bytes4 data, bytes calldata retdata) external;
function mockCall(
address where,
uint256 value,
bytes4 data,
bytes calldata retdata
) external;
You are correct, this should be additive - not deprecating the current implementation |
|
looks good, I'll push a change to make the same for |
zerosnacks
reviewed
Nov 7, 2024
zerosnacks
reviewed
Nov 7, 2024
zerosnacks
approved these changes
Nov 7, 2024
|
Woot, thank you all! |
yash-atreya
added a commit
to foundry-rs/forge-std
that referenced
this pull request
Nov 8, 2024
Ref: foundry-rs/foundry#9267 Adds the following overloads for `vm.mockCall`. ```solidity function mockCall(address callee, bytes4 data, bytes calldata returnData) external; function mockCall(address callee, uint256 msgValue, bytes4 data, bytes calldata returnData) external; function mockCallRevert(address callee, uint256 msgValue, bytes4 data, bytes calldata revertData) external; function mockCallRevert(address callee, bytes4 data, bytes calldata revertData) external; ```
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
* feat(`cheatcodes`): mockCall with bytes4 * fix * fix
thomas-lamb-tech
pushed a commit
to thomas-lamb-tech/std_forge
that referenced
this pull request
Dec 26, 2024
Ref: foundry-rs/foundry#9267 Adds the following overloads for `vm.mockCall`. ```solidity function mockCall(address callee, bytes4 data, bytes calldata returnData) external; function mockCall(address callee, uint256 msgValue, bytes4 data, bytes calldata returnData) external; function mockCallRevert(address callee, uint256 msgValue, bytes4 data, bytes calldata revertData) external; function mockCallRevert(address callee, bytes4 data, bytes calldata revertData) external; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #9213
Solution
bytes4 dataarg to pass the selector liketoken.balanceOf.selectorinstead ofabi.encodeWithSelector