fix: add back silent option in Anvil's NodeConfig
#9181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setting, overrides as true in test
zerosnacks
changed the title
--silent option in Anvil's NodeConfigsilent option in Anvil's NodeConfig
grandizzy
reviewed
Oct 24, 2024
zerosnacks
requested review from
DaniPopes,
klkvr,
mattsse and
yash-atreya
as code owners
mattsse
approved these changes
Oct 24, 2024
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
* add quiet handling for Anvil tests using NodeConfig * add back `silent` flag, inheriting default from global shell --quiet setting, overrides as true in test * fix unrelated failing test * revert fix, moved to foundry-rs#9182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes regression of expected behavior cd71da4#diff-821677e726ecf3de9d59a8e9cc1aef2c64650c7b04452be6860ed123ad29e17aL261
Regression caused startup logs to appear when running tests, this was previously not the case
A future enhancement to help catch this would be to use Snapbox for Anvil's tests too
Solution
Previously worked correctly when global
anvil --quiet/anvil --silentflags are set but the option to configure this viaNodeConfigwas lost, this restores it and correctly defaults now again to silent forNodeConfig::test()Note: CI is currently failing due to unrelated flaky test, addressed in #9182