Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(evm): improve err messaging #8936

Closed
wants to merge 1 commit into from
Closed

fix(evm): improve err messaging #8936

wants to merge 1 commit into from

Conversation

yash-atreya
Copy link
Member

Motivation

Ref #8908

Solution

Make errors more verbose.

@klkvr
Copy link
Member

klkvr commented Sep 23, 2024

why isn't wrap_err enough here?

mattsse
mattsse reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, wrap_error should just add the error message to the existing error so it would display as stacked error:

message
error

@DaniPopes DaniPopes deleted the yash/improve-evm-errs branch September 23, 2024 20:18
@grandizzy grandizzy mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash-atreya @klkvr @mattsse