fix(cheatcodes): reset interpreter gas to the value of gas spent #8481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
changed the title
grandizzy
force-pushed
the
fix-8383
branch
2 times, most recently
from
ce91c7a
to
7850720
Compare
grandizzy
changed the title
grandizzy
changed the title
grandizzy
requested review from
DaniPopes,
mattsse,
klkvr and
Evalir
as code owners
DaniPopes
reviewed
Jul 20, 2024
crates/cheatcodes/src/inspector.rs
Outdated
| // It would be nice if we had access to the interpreter in | ||
| // `call_end`, as we could just do this there instead. | ||
| interpreter.gas = | ||
| Gas::new(interpreter.gas.limit() - interpreter.gas.remaining()); |
There was a problem hiding this comment.
thanks, missed that, updated in 2d3788d
mattsse
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #8383
Solution