docs: document unit for --with-gas-price #8370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRBerg
requested review from
DaniPopes,
mattsse,
klkvr and
Evalir
as code owners
|
That's the default yes, you can also specify the unit after the value like "1 gwei"; see |
Evalir
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
should be g2g. will leave up to @DaniPopes & rest of team to approve and merge this :)
DaniPopes
approved these changes
Jul 26, 2024
mattsse
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is not clear in which unit the gas price should be passed when running
forge script --with-gas-price.Solution
Mention the unit at the end of the description - "in wei".