Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable maxperf for docker cargo builds #8343

Closed

Conversation

somehowchris
Copy link

Motivation

There's a maxperf profile, so why not build release builds for like ghcr in that profile? build once, benefit many

Solution

Replace the --release with --profile maxperf in the Dockerfile

@DaniPopes
Copy link
Member

DaniPopes commented Jul 3, 2024

I would rather not since it takes significantly longer for little benefit. I think we also wanted to use foundryup for dockerfiles but I don't know if we have an issue for that cc @mattsse @grandizzy @zerosnacks

@DaniPopes DaniPopes closed this Jul 3, 2024
@grandizzy
Copy link
Collaborator

I would rather not since it takes significantly longer for little benefit. I think we also wanted to use foundryup for dockerfiles but I don't know if we have an issue for that cc @mattsse @grandizzy @zerosnacks

yeah, it is tracked in #7512 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants