feat: add mixed mining mode #8280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Jul 16, 2024
crates/anvil/src/eth/miner.rs
Outdated
| match (auto_txs, fixed_txs) { | ||
| // Both auto and fixed transactions are ready, combine them | ||
| (Poll::Ready(mut auto_txs), Poll::Ready(mut fixed_txs)) => { | ||
| auto_txs.append(&mut fixed_txs); |
There was a problem hiding this comment.
there might be the case here where both include the the same txs so we need to make the set unique, basically only append if the not included in auto_txs
we can simply filter by hash
mattsse
force-pushed
the
feat/add-mixed-mining-mode
branch
from
a843d38
to
3523c8b
Compare
mattsse
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solves #7901
Solution
Add a new mining mode called
mixedwhich allows for both auto and interval to be set and will poll both cases