-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty printed logs and events in cast run #8207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we accept this, we should also do this for calls too. Please also update revm-inspector's implementation as for now they are separate, but we want to merge them in the future. |
looking at the failing tests, I think we want to this for topics > 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply these changes in revm-inspectors
and I will review there. I don't want to modify the code here
Maybe it's just because I'm not used to this format, but I find it verbose and hard to skim traces for the call I am looking for now. Perhaps the broken lines are throwing me off With long traces especially, terminal scrollback buffers will now cut off more of the trace Either way this will just be different user's personal preference so ideally we move it behind a trace configuration flag, ref #3390 |
Hi @ioterw, since the last update we've entirely moved to use the Given that there is no actionable item left here I think it makes sense to close this ticket in favor of a future one to be opened by @ioterw in https://github.com/paradigmxyz/revm-inspectors |
Motivation
Recently I got quite big events in cast, so made them a bit more pretty printed, also fixed padding of topics in logs
Solution
Before:
After:
P.S. I don't remember any log bigger than 4 topics, so removed number 13 for string formating.