Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(foundryup): robustness checks and shell improvements #7970

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sambacha
Copy link
Contributor

@sambacha sambacha commented May 22, 2024

Motivation

foundryup is not robust.

make it robust.

Solution

sanity checks and etc.

check_bins_in_use

Introduces a new function, check_bins_in_use which makes sure that something like forge build -w isn't running.

fix check_cmd

also fixes check_cmd output

fix curl/wget

enforce TLS v1.2

Note

need_cmd curl actually would prevent wget from running, as the script would error out and there is no if/else logic to fail over to using wget anyway.

@sambacha
Copy link
Contributor Author

really some testing of the scripts should be implemented, however after trying to get Docker container testing added, not willing to just yolo some tests into here

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe @onbjerg or @DaniPopes know how to review this?

@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 31, 2024
@zerosnacks zerosnacks added the A-installer Area: installer label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-installer Area: installer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants