Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cheatcodes): solc 0.6.2 compatibility #7694

Merged
merged 1 commit into from
Apr 17, 2024
Merged

chore(cheatcodes): solc 0.6.2 compatibility #7694

merged 1 commit into from
Apr 17, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Apr 17, 2024 •
edited
Loading

Motivation

accommodate new cheatcodes in forge-std, solc 0.6.2 compatibility
foundry-rs/forge-std#539 (comment)

Solution

  • fix isContext shadowing in isContext cheatcode
  • use calldata location for input in indexOf cheatcode

mattsse
mattsse approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mattsse mattsse merged commit 46abc42 into foundry-rs:master Apr 17, 2024
19 checks passed
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grandizzy @mattsse