Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make batch size as a option #7540

Merged
merged 6 commits into from
Apr 6, 2024

Conversation

hoaleee
Copy link
Contributor

@hoaleee hoaleee commented Apr 2, 2024

Make batch size as a option.

Motivation

We are developing a network based on zkevm - a new evm platform. We are trying to increase compatibility of MUD Framework and zkevm. We found that with the default batch size of 100, zkevm may not be able to handle it, with the --slow option the waiting time is too long.

Solution

So we added batch size as an option to increase customization compatibility with many chains.

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @klkvr

Also needs cargo +nightly fmt

crates/script/src/broadcast.rs Outdated Show resolved Hide resolved
crates/script/src/lib.rs Outdated Show resolved Hide resolved
crates/script/src/lib.rs Outdated Show resolved Hide resolved
crates/script/src/lib.rs Outdated Show resolved Hide resolved
crates/script/src/broadcast.rs Outdated Show resolved Hide resolved
hoaleee and others added 5 commits April 5, 2024 17:54
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
@hoaleee hoaleee requested a review from DaniPopes April 6, 2024 14:17
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit 0c961f7 into foundry-rs:master Apr 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants