Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cast): let cast interface look for abi file in the out folder #7528

Closed

Conversation

DrakeEvans
Copy link
Contributor

@DrakeEvans DrakeEvans commented Mar 30, 2024

Motivation

cast interface command needs a full file path to the abi which is annoying to look up. Other commands just need the contract name

Solution

If a name is passed instead of an address/abi_path we look for it in the out folder (which is loaded from the config file)

Help Needed

I'm not sure where the proper location for the find_file_in_folders function is. I would appreciate help getting this PR over the line. As of now it is missing tests

@DrakeEvans DrakeEvans force-pushed the feature/cast-interface-find-abi branch from f9a2df5 to f8cf8d4 Compare April 1, 2024 20:47
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 31, 2024
@zerosnacks
Copy link
Member

Thanks for the PR! Supportive of the feature. Would be great to get this ready for review / merged - do you see any blockers @DrakeEvans? The proper location of find_file_in_folders can be handled in the review

@zerosnacks zerosnacks added the C-cast Command: cast label Jul 31, 2024
@zerosnacks zerosnacks marked this pull request as draft July 31, 2024 11:50
@zerosnacks zerosnacks changed the title DRAFT: feat(cast): let cast interface look for abi file in the out folder feat(cast): let cast interface look for abi file in the out folder Jul 31, 2024
@DrakeEvans
Copy link
Contributor Author

I dont think I have anything else Id do to get ready for review. Unfortunately I dont have the bandwidth to take this over the line but happy to answer any questions via tg etc.

@zerosnacks
Copy link
Member

I dont think I have anything else Id do to get ready for review. Unfortunately I dont have the bandwidth to take this over the line but happy to answer any questions via tg etc.

No problem! Thanks, I'll pick it up from here

@zerosnacks zerosnacks self-assigned this Jul 31, 2024
@zerosnacks
Copy link
Member

Decided to turn this into a ticket here #8580 given there have been improvements to the way interactions with artifacts occur / deals with certain edge cases

@zerosnacks zerosnacks closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cast Command: cast
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants