feat(anvil): --disable-tracing
#7445
Conversation
| let mut inspector = Inspector::default(); | ||
| if !self.disable_tracing { | ||
| inspector = inspector.with_tracing(); | ||
| if self.enable_steps_tracing { | ||
| inspector = inspector.with_steps_tracing(); | ||
| } |
There was a problem hiding this comment.
we can leave the setup as is, but if tracing is disabled we need to change this:
foundry_evm::utils::new_evm_with_inspector(&mut *self.db, env, &mut inspector);
to evm setup without inspector, which is always faster than with any inspector
| match evm.transact_commit() { | ||
| Ok(exec_result) => exec_result, | ||
| Err(err) => { | ||
| warn!(target: "backend", "[{:?}] failed to execute: {:?}", transaction.hash(), err); | ||
| match err { | ||
| EVMError::Database(err) => { | ||
| return Some(TransactionExecutionOutcome::DatabaseError( | ||
| transaction, | ||
| err, |
There was a problem hiding this comment.
I think we don't need the duplication here if we make the if else block return the result?
There was a problem hiding this comment.
The issue was building the evm with different types, one with an inspector and one without.
There was a problem hiding this comment.
I think we don't need the duplication here if we make the if else block return the result?
@mattsse The if else block already returns the exec_result.
|
Would be great to get this updated / merged @yash-atreya when you have opportunity |
Motivation
Closes #7442
Solution
Add CLI arg
--disable-tracingto disable all tx tracing in anvil. Default value isfalse.