Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(evm): executor API, merge evm result types #7422

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

DaniPopes
Copy link
Member

  • rm IntoFunction, split into dyn and sol API
  • merge all result types by using RawCallResult as the base

@DaniPopes DaniPopes changed the title refactor(evm): executor API, merge evm result types [WIP] refactor(evm): executor API, merge evm result types Mar 18, 2024
@DaniPopes DaniPopes changed the title [WIP] refactor(evm): executor API, merge evm result types refactor(evm): executor API, merge evm result types Mar 18, 2024
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh hell yeah

Copy link
Member

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! much cleaner now

@DaniPopes DaniPopes merged commit 04fca21 into master Mar 18, 2024
19 checks passed
@DaniPopes DaniPopes deleted the dani/refactor-executor branch March 18, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants