fix(forge): fix debugger buffer-write highlight else-if fallthrough #7126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Was a bit late pushing my last commit to #7110, apologies cc @DaniPopes
The check on
read_accesses
should check both that it's Some and that the active buffer matches, else writes to the memory buffer won't get highlighted.This doesn't feel particularly elegant, so let me know if there's a better way to check if a member is Some and check against a member of that member in the same conditional.
As noted in a comment in the previous PR, behavior should be tweaked in the future to allow simultaneous read+write highlights for MCOPY
Solution