Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore ETHERSCAN_API_KEY if empty #6918

Merged

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jan 27, 2024

ref #6651

using an empty etherscan key can lead to various issues. this happens if the key is set to an empty string: ETHERSCAN_API_KEY=""

This includes additional checks and ignores the key if empty

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stupid how env vars work -.-

@onbjerg onbjerg merged commit 2249e07 into foundry-rs:master Jan 27, 2024
19 checks passed
@mattsse mattsse mentioned this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants