Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cast): support cast wallet derive-private-key #6774

Merged
merged 4 commits into from
Jan 15, 2024
Merged

feat(cast): support cast wallet derive-private-key #6774

merged 4 commits into from
Jan 15, 2024

Conversation

fenghaojiang
Copy link
Contributor

@fenghaojiang fenghaojiang commented Jan 12, 2024 •
edited
Loading

Motivation

support cast wallet get-private-key from mnemonic and mnemonic_index
And I think derive-private-key would be more appropriate.

This PR implemented the feature request from issue #6729.

Closes #6729

mnemonic_index would be 0 by default.

cast wallet derive-private-key "ten able puppy cart gadget change health must creek human bracket above"  
- Account:
Address:     0x688DB4fC60816A5838485d0ab9b4ef358f849c35
Private key: 0x9a900f2e6171a60dfd7871226c8a2a55e754678e62765d1ab189097e62dee418

cast wallet derive-private-key "ten able puppy cart gadget change health must creek human bracket above" 1
- Account:
Address:     0x81EbdaCabf245849412183f13cb83E9a7ffF2da4
Private key: 0x5fcd6ddc5471acbe3c0f48b43c5a0c4ca364b137a0340f01e38efbb85e7ce0ac

@fenghaojiang fenghaojiang changed the title feat: support cast wallet get-private-key feat(cast): support cast wallet get-private-key Jan 12, 2024
@fenghaojiang fenghaojiang changed the title feat(cast): support cast wallet get-private-key feat(cast): support cast wallet derive-private-key Jan 12, 2024
DaniPopes
DaniPopes approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending @Evalir and/or @mattsse

mattsse
mattsse approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable, lgtm

thank you

@mattsse mattsse merged commit 54cd6a4 into foundry-rs:master Jan 15, 2024
19 checks passed
@cdump cdump mentioned this pull request Jan 20, 2024
Merged
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cast wallet get-private-key
3 participants
@fenghaojiang @mattsse @DaniPopes