fix: don't leak env parser error #6375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
approved these changes
Nov 20, 2023
mattsse
force-pushed
the
matt/env-error-cleanup
branch
from
bd5701b
to
4039f56
Compare
mattsse
force-pushed
the
matt/env-error-cleanup
branch
from
4039f56
to
a0a9100
Compare
DaniPopes
requested changes
Nov 20, 2023
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6374
prevents leaking env value via
alloy::parser::Error