fix(fmt): fix indent closing parenthesis enclosed in { } (#7557)

* fix(fmt): fix indent closing parenthesis enclosed in { } * Fix testdata bad formatting
foundry-rs · Apr 4, 2024 · 0875a83 · 0875a83
1 parent f6208d8
commit 0875a83
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 2 deletions.
diff --git a/crates/fmt/src/formatter.rs b/crates/fmt/src/formatter.rs
@@ -895,7 +895,7 @@ impl<'a, W: Write> Formatter<'a, W> {
                 write_chunk!(fmt, "{}", stringified.trim_start())
             })?;
             if !last.content.trim_start().is_empty() {
-                self.write_whitespace_separator(true)?;
+                self.indented(1, |fmt| fmt.write_whitespace_separator(true))?;
             }
             let last_chunk =
                 self.chunk_at(last.loc_before(), last.loc_next(), last.spaced, &last.content);

diff --git a/crates/fmt/testdata/Repros/fmt.sol b/crates/fmt/testdata/Repros/fmt.sol
@@ -5,3 +5,15 @@ function errorIdentifier() {
     bytes memory error = bytes("");
     if (error.length > 0) {}
 }
+
+// https://github.com/foundry-rs/foundry/issues/7549
+function one() external {
+    this.other({
+        data: abi.encodeCall(
+            this.other,
+            (
+                "bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla"
+            )
+        )
+    });
+}
diff --git a/crates/fmt/testdata/Repros/original.sol b/crates/fmt/testdata/Repros/original.sol
@@ -5,3 +5,15 @@ function errorIdentifier() {
     bytes memory error = bytes("");
     if (error.length > 0) {}
 }
+
+// https://github.com/foundry-rs/foundry/issues/7549
+function one() external {
+    this.other({
+        data: abi.encodeCall(
+            this.other,
+            (
+                "bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla"
+            )
+            )
+    });
+}
diff --git a/testdata/default/cheats/RecordAccountAccesses.t.sol b/testdata/default/cheats/RecordAccountAccesses.t.sol
@@ -943,7 +943,7 @@ contract RecordAccountAccessesTest is DSTest {
                 data: abi.encodeCall(
                     Create2or.create2,
                     (bytes32(0), abi.encodePacked(type(ConstructorStorer).creationCode, abi.encode(true)))
-                    ),
+                ),
                 reverted: false,
                 storageAccesses: new Vm.StorageAccess[](0),
                 depth: 1