cheats: fix assume not precompile #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the cancun hardfork, the point evaluation precompile was added at `address(10)` which the `assumeNotPrecompile` implementation did not take into account. Pectra is scheduled to include BLS precompiles and likely more precompiles will be introduced in other future hardforks. We might as well reserve the least significant byte for Ethereum precompiles, as the address space is large and there is no need to make calls from these addresses, and in return code will not break on new EVM specs. This was causing test failures in the Optimism test suite when we updated the EVM version to cancun.
mds1
reviewed
Aug 6, 2024
src/StdCheats.sol
Outdated
| // These should be present on all EVM-compatible chains. | ||
| vm.assume(addr < address(0x1) || addr > address(0x9)); | ||
| // These are reserved by Ethereum and may be on all EVM-compatible chains. | ||
| vm.assume(addr < address(0x1) || addr > address(0x100)); |
There was a problem hiding this comment.
I agree with the larger upper bound so this is more future-proof. Do you have a source for the 0x100 value? I've only seen https://eips.ethereum.org/EIPS/eip-1352 which reserves through 0xffff.
There was a problem hiding this comment.
The genesis for testnets includes 1 wei for the precompiles in the range address(0) to address(0xff). See https://github.com/eth-clients/holesky/blob/main/metadata/genesis.json
I meant to follow this standard, will update the PR to use address(0xff) rather than address(0x100)
Use the address range of precomiples that testnets use, see https://github.com/eth-clients/holesky/blob/main/metadata/genesis.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the cancun hardfork, the point evaluation precompile was added at
address(10)which theassumeNotPrecompileimplementation did not take into account. Pectra is scheduled to include BLS precompiles and likely more precompiles will be introduced in other future hardforks. We might as well reserve the least significant byte for Ethereum precompiles, as the address space is large and there is no need to make calls from these addresses, and in return code will not break on new EVM specs.This was causing test failures in the Optimism test suite when we updated the EVM version to cancun.