feat(cheatcodes): Add vm.prevrandao to Vm.sol
#373
Conversation
src/Vm.sol
Outdated
| // Sets block.difficulty | ||
| function difficulty(uint256 newDifficulty) external; | ||
| // Sets block.prevrandao | ||
| function prevrandao(bytes32 newPrevrandao) external; |
There was a problem hiding this comment.
Are these aliases for each other or will they revert depending on the EVM version you have selected in foundry.toml? If the latter, might be nice to document that in the comments here
There was a problem hiding this comment.
Ah, actually, that's a great point—these will fail silently depending on which EVM version you have. They've not been configured/changed to revert (and REVM does not fail either). We should probably update these to have this behavior
There was a problem hiding this comment.
Sounds good, I'll hold off on merging this in the meantime then if you think that change will be ready soon
There was a problem hiding this comment.
Following up with foundry-rs/foundry#4904
There was a problem hiding this comment.
With foundry-rs/foundry#4904 merged, @Evalir do you mind pushing a commit to tweak these comments so they're a bit more self-documenting?
|
Ah shoot closed this accidentally by updating my fork. Will reopen |
Follow up to foundry-rs/foundry#4856