Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solidity-scripting.md #666

Closed
wants to merge 1 commit into from

Conversation

duelinggalois
Copy link

Instructions imply that the startBroadcast function takes a uint256 rather than an address

    // Has all subsequent calls (at this call depth only) create transactions that can later be signed and sent onchain
    function startBroadcast(address) external;

Instructions imply that the `startBroadcast` function takes a uint256 rather than an address

```
    // Has all subsequent calls (at this call depth only) create transactions that can later be signed and sent onchain
    function startBroadcast(address) external;
```
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, there are functions for both:

https://github.com/foundry-rs/forge-std/blob/master/src/Vm.sol#L113-L116

but should probably be mentioned here

@duelinggalois
Copy link
Author

hmm, there are functions for both:

https://github.com/foundry-rs/forge-std/blob/master/src/Vm.sol#L113-L116

but should probably be mentioned here

Looks like my version is out of date so I don't have that function signature.

   add41d3..2a2ce36  master                -> origin/master

@mattsse
Copy link
Member

mattsse commented Sep 13, 2024

this is outdated

@mattsse mattsse closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants