setup-environment-internal: fix regressions #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoropaniuk
reviewed
Jan 25, 2024
quaresmajose
force-pushed
the
setup-environment-internal
branch
from
b461ece to
76e4eb8
Compare
quaresmajose
added
ok-to-test
We can't delete the LMP_VERSION_CACHE on CI because it is still needed in several places even after being used here. So add a new check that checks where we are executing. Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
quaresmajose
force-pushed
the
setup-environment-internal
branch
from
76e4eb8 to
bc4663c
Compare
^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.