Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #86

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Update CONTRIBUTING.md #86

merged 4 commits into from
Mar 13, 2024

Conversation

Ssukriti
Copy link
Collaborator

Description of the change

just minor cleanups before announcing to community

Related issue number

small change- no issue

How to verify the PR

I checked preview to make sure changes were rendered and links work.

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

Signed-off-by: Sukriti Sharma <Ssukriti@users.noreply.github.com>
@kellyaa
Copy link
Member

kellyaa commented Mar 12, 2024

LGTM

Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>
Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>
Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>
Copy link
Collaborator

@alex-jw-brooks alex-jw-brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ssukriti Ssukriti merged commit cd9efb1 into main Mar 13, 2024
5 checks passed
jbusche pushed a commit to jbusche/fms-hf-tuning that referenced this pull request Mar 25, 2024
* Update CONTRIBUTING.md

Signed-off-by: Sukriti Sharma <Ssukriti@users.noreply.github.com>

* add architecture record templates

Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>

* update link

Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>

* update broken link

Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>

---------

Signed-off-by: Sukriti Sharma <Ssukriti@users.noreply.github.com>
Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>
anhuong pushed a commit to anhuong/fms-hf-tuning that referenced this pull request Apr 3, 2024
* Update CONTRIBUTING.md

Signed-off-by: Sukriti Sharma <Ssukriti@users.noreply.github.com>

* add architecture record templates

Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>

* update link

Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>

* update broken link

Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>

---------

Signed-off-by: Sukriti Sharma <Ssukriti@users.noreply.github.com>
Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants