Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local inference merged models #43

Conversation

alex-jw-brooks
Copy link
Collaborator

@alex-jw-brooks alex-jw-brooks commented Feb 13, 2024

Depends on #32

This PR adds support to the local inference script for merged models; if the adapter config patcher fails to find the adapter config, it falls back to trying to load the model as a normal transformers model through AutoModelForCausalLM instead of Peft.

No changes are needed to the inference method since the generate interface is unchanged. This change has been tested with a merged llama 7b model.

@alex-jw-brooks alex-jw-brooks marked this pull request as ready for review February 13, 2024 20:32
anhuong
anhuong previously approved these changes Feb 14, 2024
Copy link
Collaborator

@anhuong anhuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! These changes look great

@hickeyma hickeyma dismissed anhuong’s stale review February 15, 2024 09:38

The merge-base changed after approval.

@alex-jw-brooks alex-jw-brooks force-pushed the local_inference_merged_models branch 2 times, most recently from 8ca6d32 to 5531594 Compare February 20, 2024 18:24
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Copy link
Collaborator

@anhuong anhuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, updated to remove changes merged into main branch

@anhuong anhuong merged commit 24e7385 into foundation-model-stack:main Feb 20, 2024
2 checks passed
sutaakar pushed a commit to sutaakar/fms-hf-tuning that referenced this pull request Sep 11, 2024
…es/appstudio-fms-hf-tuning-patch-release

Red Hat Konflux update fms-hf-tuning-patch-release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants