fix: crash when output directory doesn't exist #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarikrishnanBalagopal
requested review from
anhuong,
Ssukriti and
alex-jw-brooks
as code owners
|
Thanks for making a pull request! 😃 |
2 tasks
|
FYA - @anhuong #359 (comment) |
Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
HarikrishnanBalagopal
force-pushed
the
fix/outputdir
branch
from
ae1d2fd
to
bc8a160
Compare
HarikrishnanBalagopal
requested review from
aluu317,
fabianlim and
kmehant
as code owners
anhuong
requested review from
Abhishek-TAMU
and removed request for
alex-jw-brooks
|
If race condition is already tested as per this, then it looks good to me. |
|
Abhishek additionally tested this in the image with the accelerate_launch.py script which worked nicely as well |
anhuong
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes crash in #359
Related issue number
#359
How to verify the PR
Run a multi GPU training with a non-existent output dir.
Was the PR tested